Skip to content

🤖 Delete unused types #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

🤖 Delete unused types #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d59ef8
Delete file `ios/HackerNews/Network/NetworkDebugger.swift` containing…
emerge-tools-ai[bot] Sep 19, 2024
2f7df09
Update project file to remove NetworkDebugger
emerge-tools-ai[bot] Sep 19, 2024
c011998
Delete NetworkDebugger in ios/HackerNews/Network/HNApi.swift
emerge-tools-ai[bot] Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ios/HackerNews.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
A40DC1FA2C20D8B60055B920 /* Previews.swift in Sources */ = {isa = PBXBuildFile; fileRef = A40DC1F92C20D8B60055B920 /* Previews.swift */; };
A413E8572A8C40E800C0F867 /* Extensions.swift in Sources */ = {isa = PBXBuildFile; fileRef = A413E8562A8C40E800C0F867 /* Extensions.swift */; };
A413E8592A8D868500C0F867 /* ThemedButtonStyle.swift in Sources */ = {isa = PBXBuildFile; fileRef = A413E8582A8D868500C0F867 /* ThemedButtonStyle.swift */; };
A423B0682BAE05FB00267DDB /* NetworkDebugger.swift in Sources */ = {isa = PBXBuildFile; fileRef = A423B0672BAE05FB00267DDB /* NetworkDebugger.swift */; };
A423B06A2BAE061600267DDB /* Flags.swift in Sources */ = {isa = PBXBuildFile; fileRef = A423B0692BAE061600267DDB /* Flags.swift */; };
A427057D2A4293B10057E439 /* HNApp.swift in Sources */ = {isa = PBXBuildFile; fileRef = A427057C2A4293B10057E439 /* HNApp.swift */; };
A427057F2A4293B10057E439 /* ContentView.swift in Sources */ = {isa = PBXBuildFile; fileRef = A427057E2A4293B10057E439 /* ContentView.swift */; };
Expand Down Expand Up @@ -77,7 +76,6 @@
A40DC1F92C20D8B60055B920 /* Previews.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Previews.swift; sourceTree = "<group>"; };
A413E8562A8C40E800C0F867 /* Extensions.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Extensions.swift; sourceTree = "<group>"; };
A413E8582A8D868500C0F867 /* ThemedButtonStyle.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ThemedButtonStyle.swift; sourceTree = "<group>"; };
A423B0672BAE05FB00267DDB /* NetworkDebugger.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = NetworkDebugger.swift; sourceTree = "<group>"; };
A423B0692BAE061600267DDB /* Flags.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Flags.swift; sourceTree = "<group>"; };
A42705792A4293B10057E439 /* HackerNews.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = HackerNews.app; sourceTree = BUILT_PRODUCTS_DIR; };
A427057C2A4293B10057E439 /* HNApp.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = HNApp.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -190,7 +188,6 @@
isa = PBXGroup;
children = (
A42705AC2A429D2E0057E439 /* HNApi.swift */,
A423B0672BAE05FB00267DDB /* NetworkDebugger.swift */,
);
path = Network;
sourceTree = "<group>";
Expand Down Expand Up @@ -559,7 +556,6 @@
A49933952AA28B6500DED8B1 /* StoryScreen.swift in Sources */,
A42705A72A42949D0057E439 /* AppViewModel.swift in Sources */,
A42705AD2A429D2E0057E439 /* HNApi.swift in Sources */,
A423B0682BAE05FB00267DDB /* NetworkDebugger.swift in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down
6 changes: 0 additions & 6 deletions ios/HackerNews/Network/HNApi.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ class HNApi {

do {
let (data, response) = try await URLSession.shared.data(from: url)
if Flags.isEnabled(.networkDebugger) {
NetworkDebugger.printStats(for: response)
}
let decoder = JSONDecoder()
let storyIds = try decoder.decode([Int64].self, from: data)
let items = await fetchItems(ids: Array(storyIds.prefix(20)))
Expand All @@ -43,9 +40,6 @@ class HNApi {
taskGroup.addTask {
let url = URL(string: "https://hacker-news.firebaseio.com/v0/item/\(id).json")!
let (data, response) = try await URLSession.shared.data(from: url)
if Flags.isEnabled(.networkDebugger) {
NetworkDebugger.printStats(for: response)
}
let decoder = JSONDecoder()
// print("Received response: \(response)")
// if let str = String(data: data, encoding: .utf8) {
Expand Down
35 changes: 0 additions & 35 deletions ios/HackerNews/Network/NetworkDebugger.swift
View file
Open in desktop

This file was deleted.