-
-
Couldn't load subscription status.
- Fork 257
[experiments] Add Tanstack Form integration #2948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
commit: |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
ad9bd16 to
a73ca98
Compare
| @@ -0,0 +1,1081 @@ | |||
| /* eslint-disable react/no-children-prop */ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just following their convention, no idea why they do this
a73ca98 to
c0036b4
Compare
c0036b4 to
fd65f9b
Compare
fd65f9b to
46002e2
Compare
https://deploy-preview-2948--base-ui.netlify.app/experiments/forms/tanstack
The validation can get a bit weird since the API and docs are huge and a bit confusing
Some findings:
TSF doesn't directly support focusing errors: https://tanstack.com/form/latest/docs/framework/react/guides/focus-management
The definition of "dirty" is different from RHF: https://tanstack.com/form/latest/docs/framework/react/guides/basic-concepts#understanding-isdirty-in-different-libraries
I have followed (at least) the PR section of the contributing guide.