Skip to content

[docs][slider] Fix a11y issues in demos #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[docs][slider] Fix a11y issues in demos #2988

wants to merge 1 commit into from

Conversation

@sai6855
Copy link
Contributor

@sai6855 sai6855 commented Oct 16, 2025 •
edited
Loading

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 16, 2025

vite-css-base-ui-example

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@2988

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@2988

commit: bd115e5

@sai6855 sai6855 added component: slider Changes related to the slider component. docs Improvements or additions to the documentation. type: bug It doesn't behave as expected. accessibility a11y labels Oct 16, 2025
@netlify
Copy link

netlify bot commented Oct 16, 2025

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit bd115e5
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/68f0db82fa3e800008a73cf3
😎 Deploy Preview https://deploy-preview-2988--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mui-bot
Copy link

mui-bot commented Oct 16, 2025 •
edited
Loading

Bundle size report

Bundle Parsed size Gzip size
@base-ui-components/react 0B(0.00%) 0B(0.00%)

Details of bundle changes

@sai6855 sai6855 requested a review from mj12albert October 22, 2025 11:46
@sai6855 sai6855 marked this pull request as ready for review October 22, 2025 11:46
mj12albert
mj12albert reviewed Nov 25, 2025
View reviewed changes
Copy link
Member

@mj12albert mj12albert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think aria-label is the least-preferred way for setting accNames; the best way would probably to add Slider.Value to the demos, and use a plain <label> like the Combobox demos, what do you think @colmtuite

(There's already a Usage guideline now about accNames and a link to a fully labelled example)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mj12albert mj12albert mj12albert left review comments

@atomiks atomiks Awaiting requested review from atomiks atomiks is a code owner

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

accessibility a11y component: slider Changes related to the slider component. docs Improvements or additions to the documentation. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[slider] Demo should show a11y best practice

3 participants

@sai6855 @mui-bot @mj12albert