Skip to content

[tabs] Fix selected/active state naming consistency #3024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[tabs] Fix selected/active state naming consistency #3024

wants to merge 3 commits into from

Conversation

@atomiks
Copy link
Contributor

@atomiks atomiks commented Oct 22, 2025 •
edited
Loading

Closes #2106 - removes instances of "selected" in favor of "active". aria-selected remains of course

Breaking changes

  • Renamed [data-selected] to [data-active] in Tabs.Tab
  • Removed [data-highlighted] (:focus-visible was already the recommendation in styles)
  • selectedTabPosition/selectedTabSize are now activeTabPosition/activeTabSize in Tabs.Indicator.State

@atomiks atomiks added component: tabs Changes related to the tabs component. breaking change Introduces changes that are not backward compatible. labels Oct 22, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 22, 2025 •
edited
Loading

vite-css-base-ui-example

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@3024

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@3024

commit: 8b47ab8

@mui-bot
Copy link

mui-bot commented Oct 22, 2025 •
edited
Loading

Bundle size report

Bundle Parsed size Gzip size
@base-ui-components/react ▼-12B(0.00%) ▼-1B(0.00%)

Details of bundle changes

Check out the code infra dashboard for more information about this PR.

@netlify
Copy link

netlify bot commented Oct 22, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 8b47ab8
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/690039244db1010008400394
😎 Deploy Preview https://deploy-preview-3024--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks atomiks force-pushed the refactor/tabs-names branch 2 times, most recently from 65555b5 to 7b0210f Compare October 22, 2025 00:54
@atomiks atomiks marked this pull request as ready for review October 23, 2025 01:15
LukasTy
LukasTy approved these changes Oct 24, 2025
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

WDYT about adding a paragraph describing the BC to anyone bumping into this PR? 🤔

@atomiks atomiks force-pushed the refactor/tabs-names branch 6 times, most recently from a1297c8 to 97a2457 Compare October 28, 2025 03:15
@atomiks atomiks force-pushed the refactor/tabs-names branch from 97a2457 to 2457351 Compare October 28, 2025 03:16
@atomiks atomiks requested a review from LukasTy October 28, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

@LukasTy LukasTy Awaiting requested review from LukasTy

Assignees

No one assigned

Labels

breaking change Introduces changes that are not backward compatible. component: tabs Changes related to the tabs component.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[tabs] Inconsistency between "selected", "highlighted" and "active" tab states

3 participants

@atomiks @mui-bot @LukasTy