[combobox][autocomplete] Add filteredItems prop to improve virtualized demos with object items
#3068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomiks
added
docs
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
force-pushed
the
feat/virtualized-filteredItems
branch
2 times, most recently
from
1816b95 to
98a0757
Compare
atomiks
force-pushed
the
feat/virtualized-filteredItems
branch
from
98a0757 to
a10dae0
Compare
mnajdova
reviewed
Oct 27, 2025
| // Floating UI tests don't require `role="row"` wrappers, so retains the number API. | ||
| cols: grid ? 2 : 1, | ||
| orientation: grid ? 'horizontal' : undefined, | ||
| disabledIndices: virtualized |
Contributor
Author
There was a problem hiding this comment.
It's not actually necessary, but I was debugging an issue with the virtualized demos which I PR'd here: #3066
mnajdova
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the
virtualizeddemos when the item values are objects. Three issues were occurring before:filteredItemsprop to the root components, which overrides the internal filtering. Two passes of filtering was occurring (external + internal) and you needed to passfilter={contains}to sync the internal and external filtering together. This reduces it to one pass and removes this need to sync the filtering.JSON.stringify()serialization was being performed on every single item, which made filtering slow. Now theuseFilterhook has the third optional paramitemToStringin its types (previously it only existed at runtime), which should be passed when externally filtering object items.React.useDeferredValue()can be used to improve typing performance while filtering work is ongoingNow with 10,000 object items, even with 20x slowdown (M4 Pro), it's speedy:
Screen.Recording.2025-10-27.at.8.26.35.am.mov