[DataGrid] Fix AggregationTreeData demo crashing
#20103
Open
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
requested review from
JCQuintas,
alexfauquette,
bernardobelchior and
prakhargupta1
as code owners
sai6855
changed the title
|
Deploy preview: https://deploy-preview-20103--material-ui-x.netlify.app/ |
sai6855
commented
Oct 27, 2025
|
|
||
| return new Date(params.value); | ||
| }, | ||
| valueFormatter: (params) => { |
Contributor
Author
There was a problem hiding this comment.
Not sure why the deployment is failing, but we can test the fix by adding this diff in https://v6.mui.com/x/react-data-grid/aggregation/#usage-with-tree-data
.
The demo no longer crashes after applying this change.
CC @Janpot do you have any insight on why deployment is failing?
Member
There was a problem hiding this comment.
Not 100% sure. I retried without cache in https://app.netlify.com/projects/material-ui-x/deploys/68ff5479d2d2ded80bddfb03. Seems to work
sai6855
requested review from
MBilalShafi and
cherniavskii
and removed request for
JCQuintas,
bernardobelchior and
prakhargupta1
MBilalShafi
approved these changes
Nov 4, 2025
MBilalShafi
changed the title
AggregationTreeData demo crashing
cherniavskii
approved these changes
Nov 5, 2025
… into fix-aggregation-demo
|
This pull request has been inactive for 30 days. Please remove the stale label or leave a comment to keep it open. Otherwise, it will be closed in 15 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #20074
working preview: https://deploy-preview-20103--material-ui-x.netlify.app/x/react-data-grid/aggregation/#usage-with-tree-data