Skip to content

r/generate_ndset: Add inverted-simplex and concave-simplex shapes, fix convex-simplex#60

Merged
MLopez-Ibanez merged 1 commit intomainfrom
copilot/update-r-files-to-match-changes
Mar 25, 2026
Merged

r/generate_ndset: Add inverted-simplex and concave-simplex shapes, fix convex-simplex#60
MLopez-Ibanez merged 1 commit intomainfrom
copilot/update-r-files-to-match-changes

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 25, 2026

Mirrors Python commit 0ddc3ba — adds two new generate_ndset() shapes to the R package and corrects the convex-simplex computation.

Changes

r/R/generate.R

  • convex-simplex: Fixed implementation from sample_sphere()^4sample_simplex()^2 (more uniform)
  • New methods: "inverted-simplex" / "inverted-linear" (1 - simplex) and "concave-simplex" (1 - convex-simplex)
  • Updated all docs/descriptions to match Python, including new IshHeSha2019regular citations for inverted convex / inverted concave terminology

r/vignettes/articles/generate.Rmd

  • Added new methods to 2D scatter plot
  • Updated convex-simplex description (squares simplex points, not sphere transform)
  • New Inverted shapes section with three side-by-side 3D plots comparing regular vs. inverted variants

r/NEWS.md

  • Added changelog entry for new shapes and convex-simplex behaviour change

Usage

generate_ndset(100, 3, "inverted-simplex", seed = 42)
generate_ndset(100, 3, "concave-simplex",  seed = 42)

…ython generate_ndset changes

Co-authored-by: MLopez-Ibanez <2620021+MLopez-Ibanez@users.noreply.github.com>
Agent-Logs-Url: https://github.com/multi-objective/moocore/sessions/90414f69-8c2c-4246-b119-24d3f1f502f8
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.32%. Comparing base (0ddc3ba) to head (06c7605).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   76.31%   76.32%   +0.01%     
==========================================
  Files          66       66              
  Lines        6599     6603       +4     
  Branches     1127     1127              
==========================================
+ Hits         5036     5040       +4     
  Misses       1255     1255              
  Partials      308      308              
Flag Coverage Δ
R 65.42% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
tests 100.00% <ø> (ø)
src 86.88% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MLopez-Ibanez MLopez-Ibanez marked this pull request as ready for review March 25, 2026 12:15
@MLopez-Ibanez MLopez-Ibanez merged commit d039e51 into main Mar 25, 2026
16 checks passed
@MLopez-Ibanez MLopez-Ibanez deleted the copilot/update-r-files-to-match-changes branch March 25, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants