Fix login censor and add register censor in chatbox history #4592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend command censoring logic to include the `/register` command, similar to `/login`. This prevents sensitive information, such as passwords, from being stored in chat input history while still recording the command for history navigation.
Member
|
How about detecting common typo's as well? For example: (These aren't valid commands) And also, it's out of scope, but ideally we can avoid such typo's from being printed to chatbox as well. It's a very common way that players get their server accounts compromised. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code fixes the unexpected behaviour of the previously introduced
/logincensor in chatbox history, as the/logincommand was appearing in chatbox history even if it wasn't used, one of examples was to write/in chat.+ extend command censoring logic to also include the
/registercommand, similar to/login.