Drop legacy logic that handles special, exotic transactions / circumstances in the pre-Sirius era#134
Merged
andreibancioiu merged 5 commits intomainfrom Jul 9, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
==========================================
- Coverage 61.90% 61.64% -0.26%
==========================================
Files 48 48
Lines 3843 3791 -52
==========================================
- Hits 2379 2337 -42
+ Misses 1310 1302 -8
+ Partials 154 152 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andreibancioiu
commented
Jul 9, 2025
| // However, since the value remains at the sender, we don't emit any operations in these circumstances. | ||
| transfersValue = transfersValue && !transformer.featuresDetector.isContractDeploymentWithSignalErrorOrIntrashardContractCallWithSignalError(tx) | ||
| } | ||
| // Special handling of: |
Collaborator
Author
There was a problem hiding this comment.
Already active, for more than 1.5 years. Older transactions of this exotic kind aren't of interest in regular production flows.
andreibancioiu
commented
Jul 9, 2025
| // - https://github.com/multiversx/mx-chain-rosetta/pull/81/files | ||
| // - https://console.cloud.google.com/bigquery?sq=667383445384:bfeb7de9aeec453192612ddc7fa9d94e | ||
| func (transformer *transactionsTransformer) extractInnerTxOperationsIfBeforeSiriusRelayedCompletelyIntrashardWithSignalError(tx *transaction.ApiTransactionResult) ([]*types.Operation, error) { | ||
| if transformer.provider.IsReleaseSiriusActive(tx.Epoch) { |
Collaborator
Author
There was a problem hiding this comment.
Already active, for more than 1.5 years. Older transactions of this exotic kind aren't of interest in regular production flows.
andreibancioiu
changed the title
andreibancioiu
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR removes all legacy handling of pre-Sirius special transactions, deprecates the activation-epoch-sirius CLI flag, bumps the version, and shortens some system test runs to optimize workflow times.
- Dropped
activation-epoch-siriusfields, methods, CLI flags, and related legacy code/tests. - Updated
RosettaMiddlewareVersionto v0.7.0. - Reduced block counts in system test workflows for faster execution.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| version/constants.go | Bumped RosettaMiddlewareVersion to v0.7.0 |
| systemtests/generate_testdata_on_network.py | Removed deprecated wait_until_epoch call |
| systemtests/config.py | Removed activation_epoch_sirius configuration field |
| systemtests/check_with_mesh_cli.py | Dropped --activation-epoch-sirius flag usage |
| server/services/transactionsTransformer.go | Removed legacy inner-tx extraction and pre-Sirius guard |
| server/services/transactionsTransformer_test.go | Deleted pre-Sirius relay tests and updated test name |
| server/services/transactionEventsController.go | Removed pre-Sirius guard from extractEventTransferValueOnly |
| server/services/transactionEventsController_test.go | Deleted pre-Sirius transferValueOnly test |
| server/services/interface.go | Removed IsReleaseSiriusActive from the interface |
| server/provider/networkProvider.go | Dropped activationEpochSirius field, argument, and method |
| server/factory/provider.go | Removed ActivationEpochSirius constructor argument |
| server/factory/interface.go | Removed IsReleaseSiriusActive from factory interface |
| cmd/rosetta/main.go | No longer passes activation-epoch-sirius to provider |
| cmd/rosetta/cli.go | Deprecated and zeroed out activation-epoch-sirius flag |
| .github/workflows/regularly_check_mainnet.yml | Reduced --num-blocks from 5000 to 3000 |
| .github/workflows/regularly_check_devnet.yml | Reduced --num-blocks from 3000 to 2000 |
| Usage: "Deprecated (not used anymore).", | ||
| Required: false, | ||
| Value: 1265, | ||
| Value: 0, |
There was a problem hiding this comment.
[nitpick] Since this flag is fully deprecated and no longer used, consider removing it entirely or at least marking it as Hidden (e.g., Hidden: true) to keep the CLI help clean.
Suggested change
| Value: 0, | |
| Value: 0, | |
| Hidden: true, |
Collaborator
Author
There was a problem hiding this comment.
Marked as hidden 👍 (will be dropped at a later time, after we alter "mx-chain-rosetta-docker").
sstanculeanu
previously approved these changes
Jul 9, 2025
danidrasovean
previously approved these changes
Jul 9, 2025
andreibancioiu
dismissed stale reviews from danidrasovean and sstanculeanu
via
bc2a38b
danidrasovean
approved these changes
Jul 9, 2025
sstanculeanu
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
activation-epoch-sirius.