5.6.10

[arhtudormorar]

Remove unused DecodeForDisplayPropsType
Upgrade sdk-dapp-ui

[gemini-code-assist]

Summary of Changes

Hello @arhtudormorar, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a version bump to 5.6.10, primarily driven by an update to the @multiversx/sdk-dapp-ui dependency. A significant aspect of this change is a thorough cleanup of the project's dependency graph, removing a large number of packages that are no longer necessary. This likely contributes to a leaner and more efficient build. Additionally, a specific type definition related to server transactions has been refactored, streamlining the codebase.

Highlights

• Dependency Upgrade: The @multiversx/sdk-dapp-ui optional dependency has been updated to version >=0.1.18 <0.2.0 in package.json.
• Extensive Dependency Cleanup: The pnpm-lock.yaml file has been regenerated, leading to the removal of numerous unused or outdated packages. This includes various @rollup, @stencil, @vue related packages, as well as several utility libraries like classnames, lodash.capitalize, postcss, qrcode, and react-dom.
• Type Definition Refactoring: The DecodeForDisplayPropsType interface has been removed from src/types/serverTransactions.types.ts, indicating a refactoring of how transaction display decoding properties are managed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• package.json
  • Updated @multiversx/sdk-dapp-ui optional dependency range to >=0.1.18 <0.2.0.
• pnpm-lock.yaml
  • Regenerated lock file to reflect updated and removed dependencies.
  • Removed numerous entries for packages such as @emotion/unitless, @lit/react, various @rollup/* packages, @stencil/* packages, @ts-morph/common, @vue/* packages, classnames, cliui@6.0.0, code-block-writer, decamelize, dijkstrajs, dom-serializer, domelementtype, domhandler, domutils, entities@4.5.0, entities@7.0.0, estree-walker, html-dom-parser, html-react-parser, htmlparser2, inline-style-parser, lodash.capitalize, lodash.inrange, lodash.range, magic-string@0.30.21, mkdirp, nanoid@3.3.11, pngjs, postcss, qrcode, react-dom@19.2.3, react-property, react-style-stringify, require-main-filename, scheduler, set-blocking, source-map-js, style-to-js, style-to-object, ts-morph, vue@3.5.26, which-module, y18n@4.0.3, yargs-parser@18.1.3, and yargs@15.4.1.
• src/types/serverTransactions.types.ts
  • Removed the DecodeForDisplayPropsType interface.

Activity

• No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request primarily involves dependency updates, including bumping the optional dependency @multiversx/sdk-dapp-ui and removing a significant number of packages from the pnpm-lock.yaml file, likely due to changes in how optional dependencies are handled. Additionally, it removes an exported TypeScript interface, DecodeForDisplayPropsType. I have identified a critical issue with this removal, as it constitutes a breaking change in what appears to be a patch release, violating semantic versioning principles.

I am having trouble creating individual review comments. Click here to see my feedback.

src/types/serverTransactions.types.ts (324-328)

Removing an exported interface like DecodeForDisplayPropsType is a breaking change for consumers of this library. Since this pull request appears to be for a patch release (judging by the PR title '5.6.10'), introducing a breaking change is not advisable as it violates semantic versioning.

If this type is no longer needed internally, consider re-adding it and marking it with @deprecated to be removed in a future major version. If immediate removal is necessary, the package version should be bumped to a new major version (e.g., 6.0.0).