Skip to content

Remove multisig wrapper #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
popenta merged 3 commits into from
Sep 25, 2025
Merged

Remove multisig wrapper #546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a5c0cf
remove multisig wrapper
popenta Sep 18, 2025
f6d1e5e
Merge branch 'feat/next' into multisig-refactoring
popenta Sep 23, 2025
7d081d6
fixes after merge
popenta Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions multiversx_sdk_cli/cli_get.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def get_account(args: Any):
if args.address:
address = Address.new_from_bech32(args.address)
else:
hrp = cli_shared._get_address_hrp(args)
hrp = cli_shared.get_address_hrp(args)
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function call should be get_address_hrp_with_fallback(args) to match the renamed function in cli_shared.py.

Copilot uses AI. Check for mistakes.
address = _get_address_from_alias_or_config(args.alias, hrp)

proxy = _get_proxy(args)
Expand All @@ -128,7 +128,7 @@ def get_storage(args: Any):
if args.address:
address = Address.new_from_bech32(args.address)
else:
hrp = cli_shared._get_address_hrp(args)
hrp = cli_shared.get_address_hrp(args)
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function call should be get_address_hrp_with_fallback(args) to match the renamed function in cli_shared.py.

Copilot uses AI. Check for mistakes.
address = _get_address_from_alias_or_config(args.alias, hrp)

proxy = _get_proxy(args)
Expand All @@ -146,7 +146,7 @@ def get_key(args: Any):
if args.address:
address = Address.new_from_bech32(args.address)
else:
hrp = cli_shared._get_address_hrp(args)
hrp = cli_shared.get_address_hrp(args)
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function call should be get_address_hrp_with_fallback(args) to match the renamed function in cli_shared.py.

Copilot uses AI. Check for mistakes.
address = _get_address_from_alias_or_config(args.alias, hrp)

proxy = _get_proxy(args)
Expand All @@ -167,7 +167,7 @@ def get_token(args: Any):
if args.address:
address = Address.new_from_bech32(args.address)
else:
hrp = cli_shared._get_address_hrp(args)
hrp = cli_shared.get_address_hrp(args)
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function call should be get_address_hrp_with_fallback(args) to match the renamed function in cli_shared.py.

Copilot uses AI. Check for mistakes.
address = _get_address_from_alias_or_config(args.alias, hrp)

proxy = _get_proxy(args)
Expand Down
5 changes: 2 additions & 3 deletions multiversx_sdk_cli/cli_governance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
)
from multiversx_sdk_cli.cli_output import CLIOutputBuilder
from multiversx_sdk_cli.config import get_config_for_network_providers
from multiversx_sdk_cli.config_env import get_address_hrp


def setup_parser(args: list[str], subparsers: Any) -> Any:
Expand Down Expand Up @@ -197,7 +196,7 @@ def _ensure_args(args: Any):


def _initialize_controller(args: Any) -> GovernanceController:
chain = args.chain if hasattr(args, "chain") else None
chain = getattr(args, "chain", None)
chain_id = cli_shared.get_chain_id(args.proxy, chain)
config = get_config_for_network_providers()
proxy_url = args.proxy if args.proxy else ""
Expand All @@ -207,7 +206,7 @@ def _initialize_controller(args: Any) -> GovernanceController:
return GovernanceController(
chain_id=chain_id,
network_provider=proxy,
address_hrp=get_address_hrp(),
address_hrp=cli_shared.get_address_hrp_with_fallback(args),
gas_limit_estimator=gas_estimator,
)

Expand Down
Loading
Loading