Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the transactions module by replacing the TransactionsController class with the TransfersController from the MultiversX SDK. The refactoring removes a significant amount of custom transaction creation logic and delegates this functionality to the SDK's built-in controller.
- Removes the custom
TransactionsControllerclass and its comprehensive test suite - Updates CLI transaction creation to use
TransfersControllerwith separate methods for native token transfers and token transfers - Adds validation to prevent providing both data and token transfers simultaneously
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| multiversx_sdk_cli/transactions.py | Removes TransactionsController class and related imports |
| multiversx_sdk_cli/tests/test_transactions.py | Completely removes test file for the deleted TransactionsController |
| multiversx_sdk_cli/tests/test_cli_transactions.py | Adds test for data and token transfer validation |
| multiversx_sdk_cli/dns.py | Updates to use TransfersController with new method signatures |
| multiversx_sdk_cli/cli_transactions.py | Major refactoring to use TransfersController and new signing approach |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| tx_computer = TransactionComputer() | ||
| if tx.guardian and not tx_computer.has_options_set_for_guarded_transaction(tx): | ||
| raise BadUsage("Guardian wallet provided but the transaction has incorrect options.") | ||
| raise BadUsage("Guardian wallet provided but the transaction has incorrect options") |
There was a problem hiding this comment.
Missing period at the end of the error message to maintain consistency with error message formatting.
Suggested change
| raise BadUsage("Guardian wallet provided but the transaction has incorrect options") | |
| raise BadUsage("Guardian wallet provided but the transaction has incorrect options.") |
danielailie
approved these changes
Sep 25, 2025
andreibancioiu
approved these changes
Sep 25, 2025
| assert tx_json["gasLimit"] == 75000 | ||
|
|
||
|
|
||
| def test_raise_error_when_data_and_transfers_provided(capsys: Any): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.