Fix BIP-32 non-hardened derivation to use public key #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BIP-32 specification requires that non-hardened child key derivation use the parent public key in the HMAC-SHA512 operation, not the private key. Previous behavior: - Used 0x00 || private_key for all derivations from private keys Fixed behavior: - Hardened derivation (index >= 0x80000000): 0x00 || private_key (correct) - Non-hardened derivation: parent public key (now matches BIP-32 spec) This fix ensures compatibility with other BIP-32 implementations including @bsv/sdk and allows correct derivation of keys from BIP-39 mnemonics. Tested against @bsv/sdk derivation to verify correctness.
- Replace base58 0.2.0 with bsv58 (SIMD-accelerated, BSV-specific) - Update address encoding/decoding to use bsv58 API - Update ExtendedKey (BIP32) encode/decode - Remove FromBase58Error, map to BadData instead - Add comprehensive CHANGELOG_BSV58.md documentation - All 129 tests pass - 5.2x faster encoding, 5.1x faster decoding (AVX2/NEON SIMD)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BIP-32 specification requires that non-hardened child key derivation use the parent public key in the HMAC-SHA512 operation, not the private key.
Previous behavior:
Fixed behavior:
This fix ensures compatibility with other BIP-32 implementations including @bsv/sdk and allows correct derivation of keys from BIP-39 mnemonics.
Tested against @bsv/sdk derivation to verify correctness.