Skip to content

Conversation

@bakajikara
Copy link
Contributor

@bakajikara bakajikara commented Oct 23, 2025

Resolves: #28022

By holding down the Alt key while editing, you can now edit the target line segment without affecting snapped items.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@cbjeukendrup cbjeukendrup requested review from a user, bkunda and mike-spa October 23, 2025 16:52
}

void LineSegment::undoMoveStartEndAndSnappedItems(bool moveStart, bool moveEnd, Segment* s1, Segment* s2)
void LineSegment::undoMoveStartEndAndSnappedItems(bool moveStart, bool moveEnd, bool moveSnapped, Segment* s1, Segment* s2)
Copy link
Contributor

@mike-spa mike-spa Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest passing EditData& to this function, and creating the variable

bool moveSnapped = !(ed.modifiers & AltModifier);

here. That way, if the behaviour needs to be changed in future it can be done by changing a single piece of code instead of two.

@cbjeukendrup cbjeukendrup added the needs design approval Feature/change requests that need a go/no-go from the design team before being worked on label Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs design approval Feature/change requests that need a go/no-go from the design team before being worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shortcut to temporarily ignore snap properties and adjust hairpin duration

3 participants