EditStaff: don't unexpectedly change clef #30811
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when pressing OK without making changes. Use Staff::defaultClefType rather than Instrument::clefType, to match `ChangeStaff`, i.e. to make the operation a no-op, as it should be. When replacing the instrument, the clef is still updated as expected, namely by `NotationParts::replaceInstrument`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…when pressing OK without making changes.
Use Staff::defaultClefType rather than Instrument::clefType, to match
ChangeStaff, i.e. to make the operation a no-op, as it should be.When replacing the instrument, the clef is still updated as expected, namely by
NotationParts::replaceInstrument.Resolves: #26362
Resolves: #24274
(N.B. in both issues, changing the name or anything isn’t even necessary to reproduce; just pressing OK/Apply is enough.)