Skip to content

Conversation

@Jojo-Schmitz
Copy link
Contributor

Resolves: #338914
Resolves: #31554

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Dec 24, 2025

@rettinghaus anything more needed for MEI?
Esp. for import?

@XiaoMigros
Copy link
Contributor

XiaoMigros commented Dec 24, 2025

Like I mentioned in the linked issue, I think allowing custom symbols for clefs is a much more sensible fix than adding an endless list of clef types.

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Dec 24, 2025

Like I mentioned in the linked issue, I think allowing custom symbols for clefs is a much more sensible fix than adding an endless list of clef types.

But that'd be a much larger task. And pretty certainly none for me.

@Jojo-Schmitz Jojo-Schmitz force-pushed the medieval-renaissance-clefs branch from 99ebec5 to b8a3a69 Compare December 24, 2025 20:44
@XiaoMigros
Copy link
Contributor

I'm not asking you specifically to implement it... but I don't think this PR is the right direction.

@Jojo-Schmitz
Copy link
Contributor Author

I disagree, MuseScore needs to know which line a clef has to go to and what the pitch of that line is.

@XiaoMigros
Copy link
Contributor

Yes, which is the same for these renaissance clefs as for existing ones...
StaffType's lineoffset as well as clef Y-offset exist as well.

case (engraving::ClefType::G8_VA):
case (engraving::ClefType::G15_MA):
case (engraving::ClefType::G_1):
case (engraving::ClefType::G_PETR):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further up in Convert::clefFromMEI there should be cases added to meiClef.GetGlyphName() for the new clefs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like done now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pardon?

@Jojo-Schmitz Jojo-Schmitz force-pushed the medieval-renaissance-clefs branch 9 times, most recently from 2c0cd5a to 402a763 Compare December 25, 2025 21:17
@Jojo-Schmitz Jojo-Schmitz force-pushed the medieval-renaissance-clefs branch from 402a763 to cc4a8e2 Compare December 26, 2025 16:57
@rpatters1
Copy link
Contributor

rpatters1 commented Dec 29, 2025

I agree with @XiaoMigros that continually adding clef types is the road to perdition. But I also recognize that clefs probably need to be refactored a bit to allow for glyph substitution. We are demanding a lot of features from that one tiny enum value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Medieval/Renaissance clefs

4 participants