-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Fix #338914: Add Medieval/Renaissance clefs #31573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix #338914: Add Medieval/Renaissance clefs #31573
Conversation
|
@rettinghaus anything more needed for MEI? |
b59b19b to
a3459db
Compare
a3459db to
21f1458
Compare
|
Like I mentioned in the linked issue, I think allowing custom symbols for clefs is a much more sensible fix than adding an endless list of clef types. |
But that'd be a much larger task. And pretty certainly none for me. |
99ebec5 to
b8a3a69
Compare
|
I'm not asking you specifically to implement it... but I don't think this PR is the right direction. |
|
I disagree, MuseScore needs to know which line a clef has to go to and what the pitch of that line is. |
|
Yes, which is the same for these renaissance clefs as for existing ones... |
| case (engraving::ClefType::G8_VA): | ||
| case (engraving::ClefType::G15_MA): | ||
| case (engraving::ClefType::G_1): | ||
| case (engraving::ClefType::G_PETR): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Further up in Convert::clefFromMEI there should be cases added to meiClef.GetGlyphName() for the new clefs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like done now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pardon?
2c0cd5a to
402a763
Compare
Resolves: [#338914](https://musescore.org/en/node/338914) Resolves: musescore#31554
it'd also export "mensural[CFG]clef" and "chant[CF]clef" to MEI, even if those won't happen yet
402a763 to
cc4a8e2
Compare
|
I agree with @XiaoMigros that continually adding clef types is the road to perdition. But I also recognize that clefs probably need to be refactored a bit to allow for glyph substitution. We are demanding a lot of features from that one tiny enum value. |
Resolves: #338914
Resolves: #31554