fix #31674: do not show courtesy for hidden time signature changes #31675
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
For the sake of continuity, I will also say here I don't think this is a bug and thus shouldn't be changed. |
Jojo-Schmitz
reviewed
Jan 7, 2026
Jojo-Schmitz
reviewed
Jan 7, 2026
| m->setHasCourtesyTimeSig(true); | ||
| } | ||
| courtesySigSeg->setTrailer(isTrailer); | ||
| courtesySigSeg->setEnabled(true); |
Contributor
There was a problem hiding this comment.
Possible alternative (untested):
courtesySigSeg->setEnabled(actualTimeSig->visible());
Makes the courtesy time sig's visibility follow the actual's one
Contributor
There was a problem hiding this comment.
That would likely have unintended consequences for multi-staff scores with mixed timesig visibility
rettinghaus
force-pushed
the
fix/courtesyTime
branch
from
0eee769 to
8735962
Compare
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #31674
Proposal to not show courtesy time signatures for invisible time signatures:
testing.courtesy.time.sig.mov
Could be extended for invisble key or clef changes.