Skip to content

Conversation

@djthorpe
Copy link
Member

No description provided.

@djthorpe djthorpe self-assigned this Dec 17, 2025
Copilot AI review requested due to automatic review settings December 17, 2025 06:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the frontend build system for the PostgreSQL Manager from using a separate workaround module to using go:generate directives with embedded filesystems. This simplifies the build process by eliminating the need for a dummy module in build/wasm/pgmanager.

Key Changes:

  • Replaced external module dependency with inline go:generate directive and embed.FS for frontend assets
  • Simplified the Makefile build targets by removing the workaround for embedding frontend files
  • Updated .gitignore to reflect the new frontend build location

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pkg/manager/httphandler/frontend_included.go New file that uses go:generate and embed.FS to handle frontend assets inline
pkg/manager/httphandler/frontend.go Removed - replaced by frontend_included.go with the new approach
go.mod Removed workaround module dependency and replace directive, plus transitive grpc dependencies
README.md Updated description to mention optional frontend (minor spelling issue with "prometheus")
Makefile Simplified pgmanager and tidy targets to use go:generate instead of manual module creation
.gitignore Added ignore pattern for the generated frontend directory in the new location

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@djthorpe djthorpe merged commit a559a9f into main Dec 17, 2025
1 check passed
@djthorpe djthorpe deleted the djt/1217/frontend branch December 17, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants