Added some dianostics #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds diagnostic output to the pgmanager server by introducing a new function to get the executable name and updating the server startup messages. However, there is a critical issue with dependency versions containing future dates.
- Added
ExecName()function to retrieve the executable name - Updated server startup output to display executable name, version, and full listening address
- Updated dependencies including grpc-gateway and related Google genproto packages
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/version/version.go | Added ExecName() function to return the base name of the executable |
| cmd/pgmanager/server.go | Updated diagnostic output to show executable name and version, improved listening address message |
| go.mod | Added gRPC-related dependencies and removed unused OpenTelemetry exports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds diagnostic output to the pgmanager server by introducing a new function to get the executable name and updating the server startup messages. However, there is a critical issue with dependency versions containing future dates.