Skip to content

App access token handling#61

Open
gr8bit wants to merge 5 commits intomweibel:masterfrom
bichinger:app-access-token-handling
Open

App access token handling#61
gr8bit wants to merge 5 commits intomweibel:masterfrom
bichinger:app-access-token-handling

Conversation

@gr8bit
Copy link
Contributor

@gr8bit gr8bit commented Feb 11, 2018

For calls requiring an app access token, use the configured app_access_token instead of taking an access token as input parameter. Deprecates the old version of these calls!

@mweibel What I did not do is wrap the app access token setter from Facebook.Config into Facebook (set_app_secret) because I couldn't think of a scenario where this would be needed... maybe you can help me with that? In which cases do you use Facebook.set_app_secret/1 or even Facebook.Config.app_secret/1?

@mweibel
Copy link
Owner

mweibel commented Jul 3, 2018

Can you fix the tests please?

@mweibel
Copy link
Owner

mweibel commented Oct 26, 2018

@gr8bit Hi, could you please update your PR and fix the tests? As to your question: not sure I understand what you mean?

@gr8bit
Copy link
Contributor Author

gr8bit commented Oct 26, 2018

Hi @mweibel! Sorry, I have been completely busy but I will catch up on this! Regarding my question: I don't know what I meant either. :D I'll get into that and hopefully understand myself again. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants