Open
Conversation
…onfiguration, deprecated old calls
Owner
|
Can you fix the tests please? |
Owner
|
@gr8bit Hi, could you please update your PR and fix the tests? As to your question: not sure I understand what you mean? |
Contributor
Author
|
Hi @mweibel! Sorry, I have been completely busy but I will catch up on this! Regarding my question: I don't know what I meant either. :D I'll get into that and hopefully understand myself again. ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For calls requiring an app access token, use the configured
app_access_tokeninstead of taking an access token as input parameter. Deprecates the old version of these calls!@mweibel What I did not do is wrap the app access token setter from Facebook.Config into Facebook (set_app_secret) because I couldn't think of a scenario where this would be needed... maybe you can help me with that? In which cases do you use
Facebook.set_app_secret/1or evenFacebook.Config.app_secret/1?