Fix Rails 5.2 incompatibility #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 2, 2018 13:42
…e` by individual `optional: true` on every `belongs_to` association We don't want the gem Engine to change the config of its parent Rails app
… without parent, it will use the column's default value 0
|
It would be good if this could get sorted out as we are trying to use this under Rails 5.2 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following my comment on PR #3, I propose this change to fix the error raised on app loading with Rails 5.2 :
My opinion is that the gem should not change the
belongs_to_required_by_defaultconfig of its parent application. In my company, we userails_wordpressas a Rails engine in a larger app, with another database and other models living aside. They should not be concerned by this setting. So I suggest to replace this global config by individualoptional: trueon everybelongs_toassociation declaration (as suggested by @brijeshror himself in his initial PR #3). I added a test on creating a Post without parent.I also update the Rails locked dependency (used in tests) to latest 5.2 version.