fixing modal not hiding because of the animation#107
Open
nicolaslazzos wants to merge 3 commits intomxck:masterfrom
Open
fixing modal not hiding because of the animation#107nicolaslazzos wants to merge 3 commits intomxck:masterfrom
nicolaslazzos wants to merge 3 commits intomxck:masterfrom
Conversation
mxck
reviewed
Mar 7, 2021
sahil-75
approved these changes
Jun 1, 2021
|
Is there any workaround for this issue for v1.2.0 + Expo SDK42? I am facing issues getting v2.0.0 to start with Expo SDK 42 to will need to stick to v1.2.0 till the other issue gets resolved. |
Owner
|
@gpsolarco you got this issue on mobile? |
|
Both Mobile and Web. |
|
Any update on this issue? thanks! |
BrodaNoel
reviewed
Oct 6, 2021
|
|
||
| // @@ TODO: Rework this | ||
| _hide = () => { | ||
| if (!!this.props.blockedHide) { |
There was a problem hiding this comment.
!! are not necessary in if statements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the
hide()method, when themenuStateis being setted asHIDDEN, this was triggering the_onMenuLayout()method, so themenuStatewas immediately being setted toANIMATING, which was causing themodalVisiblevariable to betrue. So, though this was an unwanted behavior, in mobile it wasn't showing, but in web, because of the modal wasn't closing, it stayed and forced you to click on the screen again so that it closed after the menu disappeared.I simply added that when the
menuStateisHIDDEN, the_onMenuLayout()method ignores that trigger.