Open
Conversation
jaumard
requested changes
Jan 25, 2026
Member
jaumard
left a comment
jaumard
left a comment
There was a problem hiding this comment.
Thanks for your PR, just few minor changes and it's good to go
| @@ -0,0 +1,13 @@ | |||
| #!/bin/sh | |||
| # This is a generated file; do not edit or check into version control. | |||
Member
There was a problem hiding this comment.
should not be in version control
pubspec.yaml
Outdated
Comment on lines
+11
to
+13
| visibility_detector: ">=0.2.0 <1.0.0" | ||
| flutter_hooks: ">=0.16.0 <1.0.0" | ||
| http: ">=0.13.1 <2.0.0" | ||
| visibility_detector: ^0.4.0 | ||
| flutter_hooks: ^0.21.3+1 | ||
| http: ^1.2.1 |
Member
There was a problem hiding this comment.
I prefer using range to avoid having to push new versions just to update deps, can you keep those just update the lower bounds
…ustments to the example app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only an update to the latest version of the dependencies and the latest SDK.
removed smoke test from example.