Store Weak Reference to Players #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I was having some issues on my Minecraft server where players were reporting that
/searchshopwasn't working, but seemingly at random. After a few weeks, I narrowed down the issue to players relogging. Once a player relogs from the server, thePlayerobject used in PlayerMenuUtility becomes stale and no longer points to the new Player object. I replacedownerwith a reference to the player's UUID and thegetPlayer()method now gets the new player object straight from Bukkit.I also did a bit of cleanup in the handler class for
/searchshopwhen I was searching for this bug.I've only discovered, and tested this bug/fix on MC 1.21.4.