Conversation
mamo3gr
reviewed
Feb 9, 2026
| func twoSum(nums []int, target int) []int { | ||
| numToIndex := make(map[int]int, len(nums)) | ||
|
|
||
| for i, n := range nums { |
There was a problem hiding this comment.
些末ですが…
numToIndex を定義しているので、n は合わせて num が一貫性の面で良いと思いました。
Suggested change
| for i, n := range nums { | |
| for i, num := range nums { |
Owner
Author
There was a problem hiding this comment.
ありがとうございます。
num のほうが numToIndex との関連が連想できて読みやすそうだと思いました。
mamo3gr
reviewed
Feb 9, 2026
| numToIndex[n] = i | ||
| } | ||
|
|
||
| return nil |
There was a problem hiding this comment.
Go的には、見つかったかどうかのboolと空のスライスを返すのが自然に感じました（前者はLeetCodeのシグネチャ上、無理なのですが…）。
あるいは panic とかですかね。
Owner
Author
There was a problem hiding this comment.
そうですね、ここは少し悩みました。
実務であれば記載いただいたようにすると思います。
環境の制約でできないので、leetcode の環境であるという前提で、 panic で何が起こったのかを明示するようにした方がわかりやすそうですね。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
今回の問題
Two Sum - LeetCode
使用言語
Go
次に解く問題
Group Anagrams - LeetCode