Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds builder fee functionality to the protocol, enabling fee sharing with designated builders for order routing.
Changes:
- Implements builder-related fields in order appendix encoding (builder_id and builder_fee_rate)
- Adds ClaimBuilderFee slow mode transaction type and encoding
- Integrates OffchainExchange contract for querying builder information
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/utils/test_slow_mode.py | Tests for ClaimBuilderFee transaction encoding |
| tests/utils/test_order_appendix.py | Tests for builder field encoding/decoding in order appendix |
| sanity/builder.py | Integration tests for builder fee functionality |
| pyproject.toml | Adds builder-sanity command entry point |
| nado_protocol/utils/slow_mode.py | Implements ClaimBuilderFee transaction encoding |
| nado_protocol/utils/order.py | Adds builder field support to appendix bit layout |
| nado_protocol/utils/init.py | Exports new builder and slow mode utilities |
| nado_protocol/indexer_client/types/models.py | Adds builder_fee fields to indexer models |
| nado_protocol/contracts/types.py | Defines ClaimBuilderFeeParams and BuilderInfo types |
| nado_protocol/contracts/deployments/*.json | Adds offchain_exchange contract addresses |
| nado_protocol/contracts/abis/IOffchainExchange.json | Contract ABI for querying builder info |
| nado_protocol/contracts/init.py | Implements claim_builder_fee and get_builder_info methods |
| nado_protocol/client/init.py | Passes offchain_exchange address to contracts context |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.