This repository was archived by the owner on May 26, 2023. It is now read-only.
Allow extra flags in the config file#29
Open
robert-zaremba wants to merge 5 commits intonamsral:masterfrom
Open
Allow extra flags in the config file#29robert-zaremba wants to merge 5 commits intonamsral:masterfrom
robert-zaremba wants to merge 5 commits intonamsral:masterfrom
Conversation
Ignore if extra flag is defined in the config file.
robert-zaremba
force-pushed
the
master
branch
from
3e63926 to
f382947
Compare
Author
|
Hello, any chance to merge this PR? |
Author
|
Can we merge this? |
|
I would very much like to see this merged as well 🙂 |
Author
|
Ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore if extra flag is defined in the config file.
For multi-service environment it's useful to have more config variables in a config file than a service needs. Having a restriction to only be able to define the variables required by the service is counter-productive.