exercise page #93
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| import { Span, Color, P, Div } from './elements.jsx' | ||
| import { css } from '../lib/dom.js' | ||
| import { NavLink } from './header.jsx' | ||
|
|
||
| css(` | ||
| li.mli { | ||
| display:block; | ||
| } | ||
|
|
||
| .warn { | ||
| outline: 1px dashed red; | ||
| padding: 0.8rem; | ||
| } | ||
|
|
||
| `) | ||
|
|
||
| export const MTitle = Object.fromEntries( | ||
| ['h1', 'h2', 'h3', 'h4', 'h5', 'h6'].map((el) => [ | ||
| el, | ||
| ({ children, ...props }) => | ||
| h( | ||
| el, | ||
| props, | ||
| <Color.Red style={{ marginRight: '1ch' }}> | ||
| {'#'.repeat(Number(el.slice(1)))} | ||
| </Color.Red>, | ||
| children, | ||
| ), | ||
| ]), | ||
| ) | ||
|
|
||
| export const MItalicWord = ({ children, color, type }) => { | ||
| return ( | ||
| <P> | ||
| <Color.Orange>{'>'}</Color.Orange> | ||
| <Color.CommentLighter>*</Color.CommentLighter> | ||
| <Span fg={color} style={{ fontStyle: 'italic' }}> | ||
| {children} | ||
| </Span> | ||
| <Color.CommentLighter>*</Color.CommentLighter> | ||
| {type === 'ps' && <Color.Orange>{'<'}</Color.Orange>} | ||
| </P> | ||
| ) | ||
| } | ||
|
|
||
| export const MLi = ({ children, link }) => { | ||
| let ColorIze = link ? Color.CyanDarker : Color.CommentLighter | ||
| return ( | ||
| <li class={`mli`}> | ||
| <NavLink href={link ? link : null} style={{ outline: !link && 'none' }}> | ||
| <Span | ||
| style={{ | ||
| padding: '0.1rem', | ||
| background: !link && 'rgba(75, 75, 75, 0.63)', | ||
| textDecoration: link && 'underline', | ||
| }} | ||
| fg={link ? 'cyan-darker' : 'white'} | ||
| > | ||
| <ColorIze>{link ? '[' : '`'}</ColorIze> | ||
| {children} | ||
| <ColorIze>{link ? ']' : '`'}</ColorIze> | ||
| </Span> | ||
| </NavLink> | ||
| </li> | ||
| ) | ||
| } | ||
|
|
||
| export const Warning = ({ children }) => { | ||
| return <Div class="warn">{children}</Div> | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name":"01-Hello There", | ||
| "description":"lorem ipsum", | ||
| "instructions":["do this", "do that","do like thaht"], | ||
| "notions":[{"name":"Loop","link":"/notions/js-loop"},{"name":"Variables","link":"/notions/js-variables"},{"name":"Conditions","link":"/notions/js-conditions"}] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,134 +1,56 @@ | ||
| import { css } from '../lib/dom.js' | ||
| import { Div, P } from '../component/elements.jsx' | ||
| import { MTitle, MItalicWord, MLi, Warning } from '../component/markdown.jsx' | ||
| import exercise from '../data/fakeExercise.json' | ||
|
|
||
| css(` | ||
| .exercise h1,.exercise h3 { | ||
| font-weight: bolder; | ||
| } | ||
|
|
||
| .exercise .instructions .description,.exercise .notions p{ | ||
| padding: 0.3rem; | ||
| } | ||
| `) | ||
| export const Exercise = () => { | ||
| return ( | ||
|
Member
There was a problem hiding this comment. pareil ici utilise le return impllicite, ca reduit l'indentation d'un niveau |
||
| <Div class="exercise"> | ||
| <MTitle.h2>{exercise.name}</MTitle.h2> | ||
| {'\n'} | ||
| <Div class="instructions"> | ||
| <MTitle.h3>Instructions</MTitle.h3> | ||
| {'\n'} | ||
| {exercise.description && ( | ||
| <P class="description">{exercise.description}</P> | ||
| )} | ||
| {'\n'} | ||
| {exercise.instructions && ( | ||
| <ul> | ||
| {exercise.instructions.map((key) => ( | ||
| <MLi key={key}>{key}</MLi> | ||
| ))} | ||
| </ul> | ||
| )} | ||
| </Div> | ||
| {'\n'} | ||
| <Div class="notions"> | ||
| <MTitle.h3>Warning</MTitle.h3> | ||
| {'\n'} | ||
| <Warning> | ||
| <MItalicWord color="red"> | ||
| To do this Exercise you should know the following concepts : | ||
| </MItalicWord> | ||
| {'\n'} | ||
| <ul> | ||
| {exercise.notions.map(({ name, link }) => ( | ||
| <MLi key={name} link={link}> | ||
| {name} | ||
| </MLi> | ||
| ))} | ||
| </ul> | ||
| </Warning> | ||
| </Div> | ||
| {'\n'} | ||
| </Div> | ||
| ) | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pas besoin du
return {}ici, ca meriterais peu etre une classe au lieu du style direct ?