-
-
Notifications
You must be signed in to change notification settings - Fork 33
Migrate unit tests to DataRow pattern #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: josesimoes <1881520+josesimoes@users.noreply.github.com>
Co-authored-by: josesimoes <1881520+josesimoes@users.noreply.github.com>
Co-authored-by: josesimoes <1881520+josesimoes@users.noreply.github.com>
Co-authored-by: josesimoes <1881520+josesimoes@users.noreply.github.com>
Co-authored-by: josesimoes <1881520+josesimoes@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@copilot Make sure to use PR template on the repo and fill in relevant sections. Only tick check lists, don't delete them. |
Updated the PR description to follow the template format with all required sections and checklists. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hi @Copilot, 😯 I'm afraid you'll have to use the PR template like the rest of us... |
…m UnitTestByte Co-authored-by: josesimoes <1881520+josesimoes@users.noreply.github.com>
Applied the same assertion pattern from commit d41914b to all numeric type tests (SByte, Int16, Int32, Int64, UInt16, UInt32, UInt64) in commit 880b0ce. Changes include:
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|



Description
Migrated unit tests to use
[DataRow]attributes following the pattern established in PR #186. This eliminates test data classes and foreach loops in favor of parameterized test methods, making tests cleaner and more maintainable.NFUnitTestSystemLib (9 files) - Migrated
Equals()tests for all primitive numeric types:TestDatahelper classes with[DataRow]attributesNFUnitTestBitConverter - Migrated 4
GetBytes*test methods:GetBytesBool,GetBytesChar,GetBytesInt16,GetBytesInt32Motivation and Context
Addressing nanoframework/Home#1159.
Following the pattern established in PR #186 to keep the code clean and allow for easier addition of new test cases in the future.
How Has This Been Tested?
Screenshots
N/A - No UI changes
Types of changes
Checklist:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.