Fix #113, Clean up CS Table Processing functions #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

thnkslprpt wants to merge 1 commit into nasa:main from thnkslprpt:fix-113-cs-table-processing-clean-up

Contributor

thnkslprpt commented Dec 1, 2024

Checklist

I reviewed the Contributing Guide.
I signed and emailed the appropriate Contributor License Agreement to GSFC-SoftwareRelease@mail.nasa.gov and copied cfs-program@lists.nasa.gov.

Describe the contribution

Fixes CS Table Processing has a few typos and unnessesary variables #113
- remove extraneous brackets
- correct typos
- simplify snprintf calls slightly
- assign true to Owned as soon it passes the ownership test instead of repeating this code 8 times (in CS_ProcessNewTablesDefinitionTable())
- ValidFile variable in CS_TableInit() is redundant

Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).

Expected behavior changes
Code is cleaner and more correct.

System(s) tested on
Debian 12 using the current main branch of cFS bundle.

Contributor Info
Avi Weiss @thnkslprpt


          Fix nasa#113, Clean up CS Table Processing functions

2178f8a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet