Workbench: pass only "enabled" args to a model run#2466
Merged
emilyanndavis merged 1 commit intonatcap:mainfrom Mar 30, 2026
Merged
Workbench: pass only "enabled" args to a model run#2466emilyanndavis merged 1 commit intonatcap:mainfrom
emilyanndavis merged 1 commit intonatcap:mainfrom
Conversation
…g form fields are enabled.
claire-simpson
approved these changes
Mar 27, 2026
Contributor
claire-simpson
left a comment
There was a problem hiding this comment.
Tested this locally and it looks good - thanks @emilyanndavis!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2436.
Specifically: the Workbench now filters model args to include only those whose corresponding form fields are enabled at the time a model is run.
Example: Carbon model with sample datastack
Log, Before
Log, After
Note the log now omits all args that are enabled only when
do_valuationisTrue(namely:lulc_bas_year,lulc_alt_year,discount_rate,price_per_metric_ton_of_c, andrate_change).Args Table, Before
Note the values listed for
lulc_bas_yearandlulc_alt_year.Args Table, After
Note that
Noneis now listed forlulc_bas_yearandlulc_alt_year.Checklist
- [ ] Updated the user's guide (if needed)