-
Notifications
You must be signed in to change notification settings - Fork 8
Dependency upgrade fixes #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency upgrade fixes #17
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## chore/migrate-render-html-with-history #17 +/- ##
=======================================================================
Coverage 99.30% 99.30%
=======================================================================
Files 57 57
Lines 1153 1153
Branches 318 316 -2
=======================================================================
Hits 1145 1145
Misses 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ca263bb to
cde2889
Compare
|
Rebased after #16 was merged — only new commits are listed now. |
jsamr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please request my review for the next one. If you cannot, I'll have to take a look at the project settings.
You're right, I'm sorry, I haven't thought about it |
5d91b60
into
native-html:chore/migrate-render-html-with-history
Small addition to #16
packages/render-html > yarn buildscript by removingpathsfromtsconfig.jsonof it andtransient-render-engine, which were causing mistakes in the structure of emitted declaration files.render-htmltests by setting thereact-test-rendererto the exact expected version