Skip to content

Conversation

@wjkg
Copy link
Collaborator

@wjkg wjkg commented Oct 31, 2025

Small addition to #16

  • fixes failing packages/render-html > yarn build script by removing paths from tsconfig.json of it and transient-render-engine, which were causing mistakes in the structure of emitted declaration files.
  • fixes render-html tests by setting the react-test-renderer to the exact expected version

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.30%. Comparing base (9843a43) to head (cde2889).
⚠️ Report is 3 commits behind head on chore/migrate-render-html-with-history.

Additional details and impacted files
@@                           Coverage Diff                           @@
##           chore/migrate-render-html-with-history      #17   +/-   ##
=======================================================================
  Coverage                                   99.30%   99.30%           
=======================================================================
  Files                                          57       57           
  Lines                                        1153     1153           
  Branches                                      318      316    -2     
=======================================================================
  Hits                                         1145     1145           
  Misses                                          8        8           
Flag Coverage Δ
css-processor 100.00% <ø> (ø)
transient-render-engine 98.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@5ZYSZ3K
Copy link
Collaborator

5ZYSZ3K commented Oct 31, 2025

@jsamr This in principle should target #16, but that PR I'll keep opened until Monday to give you a week to review - and to keep everything in one place, we created this PR, which includes all the changes from the previous one

@wjkg wjkg force-pushed the chore/fix-ts-build branch from ca263bb to cde2889 Compare November 4, 2025 11:27
@wjkg
Copy link
Collaborator Author

wjkg commented Nov 4, 2025

Rebased after #16 was merged — only new commits are listed now.

Copy link
Contributor

@jsamr jsamr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please request my review for the next one. If you cannot, I'll have to take a look at the project settings.

@5ZYSZ3K
Copy link
Collaborator

5ZYSZ3K commented Nov 5, 2025

Please request my review for the next one. If you cannot, I'll have to take a look at the project settings.

You're right, I'm sorry, I haven't thought about it
I assigned you to the other one that is pending

@5ZYSZ3K 5ZYSZ3K merged commit 5d91b60 into native-html:chore/migrate-render-html-with-history Nov 7, 2025
7 checks passed
@wjkg wjkg deleted the chore/fix-ts-build branch November 14, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants