WIP: adapt our "headerMaxLength" plugin to take in account reverts#233
Open
knocte wants to merge 5 commits intonblockchain:masterfrom
Open
WIP: adapt our "headerMaxLength" plugin to take in account reverts#233knocte wants to merge 5 commits intonblockchain:masterfrom
knocte wants to merge 5 commits intonblockchain:masterfrom
Conversation
This way their purpose is more understandable.
It is even more weird when used in plural, which is how it was shown in a plugin test, meh.
They have failing CI because I haven't implemented them yet.
This makes maxLineHeader plugin respect the exceptions of titles that are too long because they are reverts or reverts of a revert.
Member
Author
|
@webwarrior-ws still not working, please have a look on Monday, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.