Skip to content

Develop -> Master merge, release v6.1.0 #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexskr merged 6 commits into from
Apr 29, 2025
Merged

Develop -> Master merge, release v6.1.0 #241

alexskr merged 6 commits into from
Apr 29, 2025

Conversation

@alexskr
Copy link
Member

@alexskr alexskr commented Apr 29, 2025

mdorf and others added 6 commits March 17, 2025 13:35
@mdorf
Gemfile.lock update
affd038
@mdorf
fixed a pullLocation throwing error even when remote file exists
125111c
@mdorf
Gemfile.lock update
9757cca
@mdorf
fix for ncbo/bioportal_web_ui#408
eb6d356
@alexskr
feat(ontology_submission): enforce correct permissions on repo files …
867f9bc 
…and dirs

- Always create repository directory with set‑GID and group‑writable mode (0o2770)
- After copying uploaded Tempfile into the repo, explicitly chmod the file to group‑writable (0o660)
- Remove unnecessary `Dir.exist?` guard; rely on idempotent `mkdir_p` and follow up with chmod
- Wrap filesystem operations in a generic rescue that surfaces concise error messages
@alexskr
Merge pull request #240 from ncbo/fix/repository-permissions-modes
bf575f8 
fix/Ensure Files Copied to Repository Have Group Write Privileges
@alexskr alexskr marked this pull request as ready for review April 29, 2025 18:05
@codecov
Copy link

codecov bot commented Apr 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.89%. Comparing base (c1bd395) to head (bf575f8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...tologies_linked_data/models/ontology_submission.rb 90.47% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #241   +/-   ##
=======================================
  Coverage   79.89%   79.89%           
=======================================
  Files          75       75           
  Lines        5506     5511    +5     
=======================================
+ Hits         4399     4403    +4     
- Misses       1107     1108    +1
Flag Coverage Δ
unittests 79.89% <90.47%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexskr alexskr merged commit 3b364f1 into master Apr 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexskr @mdorf