Notice admin updated by dhruvhacks · Pull Request #225 · ncs-jss/HTTP_200

dhruvhacks · 2017-09-25T14:19:00Z

Following PR fixes #52 and fixes #170
Notices bookmarked by users are listed at end of that specific notice now.
Admin Interface

displaying bookmarked notice section at the end of edit notice menu

RishabhJain2018 · 2017-09-25T14:24:40Z

@dhruvhacks Can you please resolve the conflicts.

dhruvhacks · 2017-09-25T15:16:28Z

@RishabhJain2018 Merge conflicts resolved and build failures fixed. Please review the PR.

RishabhJain2018 · 2017-09-25T16:22:36Z

notices/admin.py

+from notices.models import Notice, BookmarkedNotice


-class NoticeAdmin(ImportExportModelAdmin):


I think we shouldn't remove the ImportExportModelAdmin from Notice admin.

RishabhJain2018 · 2017-09-25T16:24:19Z

notices/admin.py

 admin.site.register(Notice, NoticeAdmin)
-admin.site.register(BookmarkedNotice, BookmarkedNoticeAdmin)
-admin.site.register(TrendingInCollege, TrendingInCollegeAdmin)
+# admin.site.register(TrendingInCollege, TrendingInCollegeAdmin)    #Unused model


Well, this isn't the unused model. we display it on the landing page of Infoconnect. Please revert this.

RishabhJain2018 · 2017-09-25T17:56:22Z

wifi/models.py

@@ -5,40 +5,50 @@



Also, I think your editor have screwed up the indentation. Can you please fix it.

RishabhJain2018 · 2017-09-25T17:57:35Z

wifi/views.py

@@ -17,116 +17,128 @@



I don't think this file is a part of this PR. Can you please remove it.

RishabhJain2018 · 2017-09-25T17:58:35Z

wifi/models.py

@@ -5,40 +5,50 @@




I don't think this file is a part of this PR. Can you please remove it.

dhruvhacks · 2017-09-26T00:09:03Z

@RishabhJain2018 All the requested changes have been reverted.
Please review the PR.

RishabhJain2018 · 2017-09-27T05:04:14Z

notices/admin.py



-class TrendingInCollegeAdmin(ImportExportModelAdmin):
+class TrendingInCollegeAdmin(admin.ModelAdmin):


The admin class change isn't the part of this PR. We can have a separate PR for it. Can you please change it.

Sure sir. 🙂

dhruvhacks · 2017-10-02T13:44:38Z

@RishabhJain2018 changes updated, Please review the PR. 🙂

RishabhJain2018 · 2017-10-06T22:01:55Z

Hey @dhruvhacks I checked it and found that it would not be a good way of displaying it, once the list populates with large number of users. Currently, we can add searching the Bookmarks admin.
Let me know your thoughts over it.

RishabhJain2018 · 2017-11-06T19:52:10Z

@dhruvhacks Any update on this??

dhruvhacks · 2018-05-15T21:22:21Z

Currently, we can add searching the Bookmarks admin.
Let me know your thoughts over it.

@RishabhJain2018
Sir,
I felt that having separate admin display for bookmarked notices would be vague since all the notices and users will be mixed within one. This PR appends a section for Bookmarked notice within the notice admin since all the users will be grouped together under a specific notice and it would be easier to access.

I checked it and found that it would not be a good way of displaying it, once the list populates with large number of users.

We may set a limit (say 10) for no. of users to be displayed who bookmarked the specific notice.
Currently admin.TabularInline method does not provide any scope for adding search bar due to it's display layouts. Moreover in case of such InlineModelAdmin, possible filter methods include filter_vertical (link) but it also requires a ManyToMany field and notices.users is a ForeignKey field.

Sorry for the late reply.

RishabhJain2018 · 2020-08-02T22:17:48Z

@dhruvhacks Feel free to merge this as well.

dhruvhacks · 2020-08-04T18:59:40Z

@RishabhJain2018 Okay sir. Will update the PR and consider merging!

Notice admin updated

38b3302

RishabhJain2018 requested changes Sep 25, 2017

View reviewed changes

Minor fixes

eda12f2

dhruvhacks force-pushed the admin_fixes branch from 264290c to eda12f2 Compare September 26, 2017 00:06

RishabhJain2018 requested changes Sep 27, 2017

View reviewed changes

dhruvhacks force-pushed the admin_fixes branch from 652d30c to eda12f2 Compare October 2, 2017 13:33

minor changes

b267319

dhruvhacks added the stale Needs re-work label Aug 4, 2020

		from notices.models import Notice, BookmarkedNotice


		class NoticeAdmin(ImportExportModelAdmin):



		class TrendingInCollegeAdmin(ImportExportModelAdmin):
		class TrendingInCollegeAdmin(admin.ModelAdmin):

Conversation

dhruvhacks commented Sep 25, 2017

Uh oh!

RishabhJain2018 commented Sep 25, 2017

Uh oh!

dhruvhacks commented Sep 25, 2017

Uh oh!

RishabhJain2018 Sep 25, 2017

Choose a reason for hiding this comment

Uh oh!

RishabhJain2018 Sep 25, 2017

Choose a reason for hiding this comment

Uh oh!

RishabhJain2018 Sep 25, 2017

Choose a reason for hiding this comment

Uh oh!

RishabhJain2018 Sep 25, 2017

Choose a reason for hiding this comment

Uh oh!

RishabhJain2018 Sep 25, 2017

Choose a reason for hiding this comment

Uh oh!

dhruvhacks commented Sep 26, 2017

Uh oh!

RishabhJain2018 Sep 27, 2017

Choose a reason for hiding this comment

Uh oh!

dhruvhacks Oct 2, 2017

Choose a reason for hiding this comment

Uh oh!

dhruvhacks commented Oct 2, 2017

Uh oh!

RishabhJain2018 commented Oct 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RishabhJain2018 commented Nov 6, 2017

Uh oh!

dhruvhacks commented May 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RishabhJain2018 commented Aug 2, 2020

Uh oh!

dhruvhacks commented Aug 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

RishabhJain2018 commented Oct 6, 2017 •

edited

Loading

dhruvhacks commented May 15, 2018 •

edited

Loading