append response body to error if it exists #191
+56
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ncw bump |
ncw
reviewed
Nov 3, 2025
There was a problem hiding this comment.
This code looks great thanks :-)
I have a small concern though - I've seen enough badly configured proxies to know that sometimes the error message will be 1MB of HTML from the proxy.
What do you think the best way around this is? Maybe limit the size of the error message?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the OpenStack Swift API it is possible to send error text in the response body, however I notice that this feature is missing in the current implementation.
Here is a suggestion to include the error text in the returned error.
From documentation:
