Open
Conversation
Owner
|
I appreciate your PR @sproctor - how confident are you with these changes? To be honest with you Kotlin/Arrow/Gradle was a short detour in my career and haven't used any of that stack for almost 3 years now, unfortunately I have no idea how the language has changed since 1.6 or how Arrow has evolved. |
Author
|
I should probably port my code to a maintained JWT library. None of the options are amazing though. The only change I'm not super confident about is removing the annotation from the Serializer. The compiler complained about it and said it was useless, then the tests passed after removing it, so I figured it was ok. The rest is just updating dependencies and switching to refreshVersions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of the dependencies were 2+ years out of date. This PR brings most of them to current versions. Arrow removed some stuff in the next release and there were some parts that I didn't understand how to migrate. Newer versions of github release seem to be broken with Kotlin scripts, or incompatible in a way that I don't understand.
I also switch from "Dependency Update" to "Refresh Versions", because it's easier for me to use and saved a lot of work in updating.