Conversation
johanseto
force-pushed
the
jlc/course-due-date-command-celery-config
branch
from
ff081b7 to
df9cf0b
Compare
andrey-canon
left a comment
andrey-canon
left a comment
There was a problem hiding this comment.
Could you split this in two different PRs, celery task and command and could you do a rebase over the branch https://github.com/eduNEXT/eox-nelp/tree/and/add_notifications_models to start with the implementation?
eox_nelp/settings/common.py
Outdated
| if COURSE_CREATOR_APP not in settings.INSTALLED_APPS: | ||
| if hasattr(settings, "INSTALLED_APPS") and COURSE_CREATOR_APP not in settings.INSTALLED_APPS: | ||
| settings.INSTALLED_APPS.append(COURSE_CREATOR_APP) | ||
|
|
There was a problem hiding this comment.
probably this will be no necessary
There was a problem hiding this comment.
you are meaning the white line?
There was a problem hiding this comment.
it fails me if I do not register the task(in the worker). At the moment the notifications task file is not called or imported in a principal file. So celery couldn't start a not registered task.
There was a problem hiding this comment.
That's why I said that probably this is not necessary, for reference check this PR I didn't need this
johanseto
changed the title
johanseto
changed the title
johanseto
changed the title
johanseto
force-pushed
the
jlc/course-due-date-command-celery-config
branch
from
d95402c to
539c8a9
Compare
johanseto
changed the title
johanseto
force-pushed
the
jlc/course-due-date-command-celery-config
branch
from
539c8a9 to
ba3dd23
Compare
2 participants
Description
This PR has two principal functions.
Useful information to include:
Checklist for Merge