Add DNS oracle protocol #917
Open
+1,015
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
reviewed
Nov 17, 2025
Member
shargon
left a comment
shargon
left a comment
There was a problem hiding this comment.
I think that it's better to define the dns server, and make a dns query, instead of http query
Member
We need DNS over HTTPS. |
Member
Then it's DoH no Dns, we should rename the oracle protocol |
shargon
reviewed
Nov 17, 2025
erikzhang
reviewed
Nov 18, 2025
shargon
reviewed
Nov 20, 2025
| CertificatePublicKey key = new() | ||
| { | ||
| Algorithm = cert.PublicKey.Oid?.FriendlyName ?? cert.PublicKey.Oid?.Value, | ||
| Encoded = Convert.ToBase64String(cert.GetPublicKey()) |
Member
There was a problem hiding this comment.
I think that it's better to construct this object inside the try/catch clause, it's possible to throw CryptographicException during cert.GetPublicKey()
Comment on lines
+256
to
+257
| client.DefaultRequestHeaders.Accept.Clear(); | ||
| client.DefaultRequestHeaders.Accept.ParseAdd("application/dns-json"); |
Member
There was a problem hiding this comment.
This can be moved to constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing