Multiple Neo4j instance support.#32
Open
undergroundwebdesigns wants to merge 6 commits intoneoid-gem:masterfrom
Open
Multiple Neo4j instance support.#32undergroundwebdesigns wants to merge 6 commits intoneoid-gem:masterfrom
undergroundwebdesigns wants to merge 6 commits intoneoid-gem:masterfrom
Conversation
added 6 commits
January 6, 2014 16:46
gremlin plugin for neo4j is borked, or doesn't like 2.0, or something. Anyway, this thing needs the rest of it's gremlin scripts replaced, which means I have to learn cypher. That's a project for tomorrow.
I realized that gremlin (and more) was borked because neoid doesn't support neo4j 2.0 yet, and I was trying to run it against that. Downgrading for now as we want proper support.
added a couple tests to cover the new ability to select a connection from the pool.
|
Cool! 👍 |
Contributor
|
No PRs are currently being merged until tests are passing again on Travis. Apologies, but I will review and implement after I have stabilized Neoid for version 0.2.0. |
Contributor
|
PRs are now being accepted. @undergroundwebdesigns if you could rebase to the latest version and test against that, I will look more into getting this functionality merged in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I'm currently working on a project where we need to be able to connect to more than one neo4j instance, so I've updated the gem to make this possible. I realize it's probably an edge case and may not be a direction you want to take the gem, but if you're interested, here are the changes. Tests pass and everything seems to work.
Cheers!