Add select boxes #275
Open
Add select boxes #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerdinand
reviewed
Dec 26, 2025
app/views/songs/index.html.erb
Outdated
| <% end %> | ||
|
|
||
| <%= form_with url: songs_path, method: :get do |form| %> | ||
| <%= form.select :language, ["English", "German"], { include_blank: true } %> |
Owner
There was a problem hiding this comment.
Eventually, these values (["English", "German"]) will have to be loaded from the database (should include all the values that are in use currently.
app/views/songs/index.html.erb
Outdated
|
|
||
| <%= form_with url: songs_path, method: :get do |form| %> | ||
| <%= form.select :language, ["English", "German"], { include_blank: true } %> | ||
| <%= submit_tag 'Apply', class: 'btn btn-primary' %> |
Owner
There was a problem hiding this comment.
'Apply' will have to be replaced with an I18n call.
Collaborator
Author
There was a problem hiding this comment.
I have now pushed this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #221.
This Pull Request adds select boxes.
Currently, songs can only be filtered by language: