Add httpclient module, using custom httphandler to do POST request#6
Open
aware-why wants to merge 1 commit intonesies:masterfrom
Open
Add httpclient module, using custom httphandler to do POST request#6aware-why wants to merge 1 commit intonesies:masterfrom
aware-why wants to merge 1 commit intonesies:masterfrom
Conversation
Author
There was a problem hiding this comment.
Just return the request object directly, to shield the builtin http_request method in urllib2.AbstractHTTPHandler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's better for urllib2_file not to change the global variable urllib2._opener but to use temporary opener object generated by urllib2.build_opener(), otherwise, maybe it will influence other modules who are also using urllib2
in the same process.