Port regression test ticket 800 to Pytests #3530
Conversation
jessica-mitchell
added
S: Normal
|
Pull request automatically marked stale! |
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
Revise ticket800 test
terhorstd
added
the
focus
shimoura
left a comment
shimoura
left a comment
There was a problem hiding this comment.
All tests passed.
Besides that, some parameters present in the Sli version are not in the Python version, but I'm not sure if this was intentional or not.
| } forall | ||
|
|
||
| %% seventh: test ConnectLayers with good kernels | ||
| good_distance_parameters [ 0.5 1.0 ] join |
There was a problem hiding this comment.
I don't see these parameters listed in the Python version. Was it intentional?
| } forall | ||
|
|
||
| %% ninth: test ConnectLayers with good weights | ||
| good_parameters [ 0.5 1.0 ] join |
There was a problem hiding this comment.
These parameters are also not listed in the Python version. Was it intentional?
| ] | ||
|
|
||
| # --- Good and bad conn specs --- | ||
| good_connspecs = [ |
There was a problem hiding this comment.
From the sli version, there are two sets of parameters I don't see here:
/connection_type /pairwise_bernoulli_on_source /synapse_model /static_synapse/connection_type /pairwise_bernoulli_on_source /delay 2.0
| /bad_layers | ||
| [ | ||
| << /shape [ 1 ] /elements /iaf_psc_alpha >> % too few elements in shape | ||
| << /shape [ 2 2 ] /elementsss /iaf_psc_alpha >> % misspelling |
There was a problem hiding this comment.
This misspelled key test case isn't present in the Python version. Not sure where it would fit, or if it was removed on purpose.
4 participants
Uses cursor
Note that this test fails, but I am unsure what the problem is, it seems to be structured nicely so maybe the issue is minor.