Skip to content

E-prop optimizations#3722

Merged
jessica-mitchell merged 11 commits intonest:mainfrom
akorgor:eprop-optimizations
Apr 17, 2026
Merged

E-prop optimizations#3722
jessica-mitchell merged 11 commits intonest:mainfrom
akorgor:eprop-optimizations

Conversation

@akorgor
Copy link
Copy Markdown
Contributor

@akorgor akorgor commented Jan 8, 2026

This PR primarily introduces optimizations to improve the runtime of the e-prop algorithms. Additionally, it resolves git check errors, updates the reference, and introduces changes to ensure deterministic computations.

Note that all commits prior to Replace insert with emplace_back for efficiency are part of PR #3721, on which this PR builds. Thus, this PR is blocked until #3721 is merged.

@akorgor akorgor requested a review from heplesser January 8, 2026 11:56
@akorgor akorgor mentioned this pull request Jan 8, 2026
2 tasks
@akorgor akorgor force-pushed the eprop-optimizations branch from c3778d6 to a19a565 Compare January 8, 2026 15:40
@akorgor akorgor marked this pull request as draft January 8, 2026 15:44
@akorgor akorgor added the P: Blocked Work on this can not continue, see comments for the particular reason label Jan 8, 2026
@akorgor akorgor force-pushed the eprop-optimizations branch 3 times, most recently from c723f34 to a2d22b9 Compare January 15, 2026 14:14
@akorgor akorgor force-pushed the eprop-optimizations branch 3 times, most recently from 78682eb to cb392e5 Compare January 22, 2026 15:10
@heplesser heplesser requested a review from JesusEV January 27, 2026 07:19
Comment thread models/eprop_iaf.cpp Outdated
@akorgor akorgor force-pushed the eprop-optimizations branch 3 times, most recently from 3b1359d to 63f6af3 Compare February 4, 2026 13:41
@clinssen clinssen added this to Models Feb 9, 2026
@github-project-automation github-project-automation Bot moved this to To do in Models Feb 9, 2026
@akorgor akorgor force-pushed the eprop-optimizations branch 2 times, most recently from 0bed45a to c010315 Compare March 28, 2026 17:17
@akorgor akorgor force-pushed the eprop-optimizations branch 2 times, most recently from a8e89b8 to a24b861 Compare April 14, 2026 07:56
@akorgor akorgor force-pushed the eprop-optimizations branch from a24b861 to 7e01613 Compare April 16, 2026 14:00
@akorgor akorgor removed the P: Blocked Work on this can not continue, see comments for the particular reason label Apr 16, 2026
@akorgor akorgor marked this pull request as ready for review April 16, 2026 14:03
@akorgor akorgor requested a review from heplesser April 16, 2026 14:06
@gtrensch gtrensch added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority labels Apr 17, 2026
@heplesser heplesser added the I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) label Apr 17, 2026
Copy link
Copy Markdown
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, approved!

@heplesser heplesser requested review from jessica-mitchell and removed request for JesusEV April 17, 2026 09:15
@heplesser
Copy link
Copy Markdown
Contributor

@jessica-mitchell This PR almost exclusively changes references to papers and some figures. I have reviewed the small code changes. Could you quickly check that the documentation updates are fine?

Copy link
Copy Markdown
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akorgor I noticed that the see also sections are empty in the model docs; i dont think this is a problem worth blocking a pr, but you may want to remove it (I can take a look later as I thought we had something autogenerating those)

@akorgor
Copy link
Copy Markdown
Contributor Author

akorgor commented Apr 17, 2026

@akorgor I noticed that the see also sections are empty in the model docs; i dont think this is a problem worth blocking a pr, but you may want to remove it (I can take a look later as I thought we had something autogenerating those)

@jessica-mitchell thank you for pointing this out. Actually, I could move the sections listing the other e-prop models there.

@akorgor
Copy link
Copy Markdown
Contributor Author

akorgor commented Apr 17, 2026

@akorgor I noticed that the see also sections are empty in the model docs; i dont think this is a problem worth blocking a pr, but you may want to remove it (I can take a look later as I thought we had something autogenerating those)

@jessica-mitchell thank you for pointing this out. Actually, I could move the sections listing the other e-prop models there.

We just discussed that this issue will be addressed later and not within this PR.

@jessica-mitchell jessica-mitchell merged commit 9c7bc95 into nest:main Apr 17, 2026
25 checks passed
@github-project-automation github-project-automation Bot moved this from To do to Done in Models Apr 17, 2026
@akorgor akorgor deleted the eprop-optimizations branch April 17, 2026 11:37
@jessica-mitchell jessica-mitchell changed the title Eprop optimizations E-prop optimizations Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants