Skip to content

fix: update edge_bundler_deno_v2 default value #6753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 31, 2025
Merged

fix: update edge_bundler_deno_v2 default value #6753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
32280c6
ci: update deno version used in workflows
mrstork Oct 30, 2025
543ebd1
fix: update edge_bundler_deno_v2 default value
mrstork Oct 30, 2025
88ba7c2
test: update snapshots
mrstork Oct 30, 2025
ec00f99
test: make test serial for windows
mrstork Oct 30, 2025
48269d9
Merge branch 'main' into deno-v2-flag-default
mrstork Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,12 @@ jobs:
os: [ubuntu-24.04, macos-14, windows-2025]
node-version: ['22']
# Must include the minimum deno version from the `DENO_VERSION_RANGE` constant in `node/bridge.ts`.
# We're adding v2.4.2 here because it's needed for the upcoming nimble release, so we can test
# those workflows ahead of time before we can update the base version across the board.
deno-version: ['v1.39.0', 'v2.2.4', 'v2.4.2']
deno-version: ['v2.4.2']
include:
- os: ubuntu-24.04
# Earliest supported version
node-version: '18.14.0'
deno-version: 'v2.2.4'
deno-version: 'v2.4.2'
fail-fast: false
steps:
# Sets an output parameter if this is a release PR
Expand Down Expand Up @@ -159,7 +157,7 @@ jobs:
- name: Setup Deno
uses: denoland/setup-deno@v1
with:
deno-version: v2.2.4
deno-version: v2.4.2
if: ${{ !steps.release-check.outputs.IS_RELEASE }}
- name: Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v6
Expand Down
8 changes: 4 additions & 4 deletions packages/build/tests/edge_functions/snapshots/tests.js.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1279,7 +1279,7 @@ Generated by [AVA](https://avajs.dev).
────────────────────────────────────────────────────────────────␊
␊
Error message␊
Error: Command failed with exit code 1: "/external/path" bundle --import-map BASE64_STRING --quiet --code-splitting --allow-import --outdir /external/path packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts␊
Error: Command failed with exit code 1: deno bundle --import-map BASE64_STRING --quiet --code-splitting --allow-import --outdir /external/path packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts␊
STACK TRACE␊
␊
export async () => ␊
Expand All @@ -1292,9 +1292,9 @@ Generated by [AVA](https://avajs.dev).
␊
Error properties␊
{␊
shortMessage: 'Command failed with exit code 1: "/external/path" bundle --import-map BASE64_STRING --quiet --code-splitting --allow-import --outdir /external/path packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts',␊
command: '"/external/path" bundle --import-map BASE64_STRING --quiet --code-splitting --allow-import --outdir /external/path packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts',␊
escapedCommand: '"/external/path" bundle --import-map "BASE64_STRING" --quiet --code-splitting --allow-import --outdir "/external/path" "packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts"',␊
shortMessage: 'Command failed with exit code 1: deno bundle --import-map BASE64_STRING --quiet --code-splitting --allow-import --outdir /external/path packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts',␊
command: 'deno bundle --import-map BASE64_STRING --quiet --code-splitting --allow-import --outdir /external/path packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts',␊
escapedCommand: 'deno bundle --import-map "BASE64_STRING" --quiet --code-splitting --allow-import --outdir "/external/path" "packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts"',␊
exitCode: 1,␊
signal: undefined,␊
signalDescription: undefined,␊
Expand Down
Binary file modified packages/build/tests/edge_functions/snapshots/tests.js.snap
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion packages/build/tests/edge_functions/tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ for (const variant of FLAG_VARIANTS) {
t.snapshot(normalizeOutput(output))
})

test(variant.id + ' - bundles Edge Functions via runCoreSteps function', async (t) => {
test.serial(variant.id + ' - bundles Edge Functions via runCoreSteps function', async (t) => {
const output = await new Fixture('./fixtures/functions_user')
.withFlags({ ...variant.flags, buildSteps: ['edge_functions_bundling'], useRunCoreSteps: true })
.runWithBuild()
Expand Down
2 changes: 1 addition & 1 deletion packages/edge-bundler/node/feature_flags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const defaultFlags = {
edge_bundler_generate_tarball: false,
edge_bundler_dry_run_generate_tarball: false,
edge_bundler_deno_v2: false,
edge_bundler_deno_v2: true,
}

type FeatureFlag = keyof typeof defaultFlags
Expand Down
Loading