Added Test and mock for getSubscriptions#38
Open
patelhir wants to merge 8 commits intonetvlies:masterfrom
Open
Added Test and mock for getSubscriptions#38patelhir wants to merge 8 commits intonetvlies:masterfrom
patelhir wants to merge 8 commits intonetvlies:masterfrom
Conversation
Contributor
|
Hi @patelhir , Sorry for the late response, I was on holiday so no Github for me last weeks. I see you've added a test. The tests still seems to fail however? Also, I can't see the diff of your PR. Everything is red and green. Seems like your editor changes every line? Could you take a look whats happening? After that I can help you with the rebasing. |
Author
|
okay, i get to know why it was failing, there were mismatch on function names. I have corrected it and uploaded again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.