Fix IOS show env power parser

[hvanderheide]

On a non-PoE switch, "PoE Pwr" will display "n/a", which won't match "\w". Changed to match non-whitespace "\S". Tested on a bunch of Cisco C9300s

Also:

• Added Error directive
• Updated index pattern (which allows this to support older switches too)
• Added support for some older cli output

[mjbear]

On a non-PoE switch, "PoE Pwr" will display "n/a", which wonn't match "\w". Changed to match non-whitespace "\S". Tested on a bunch of Cisco C9300s

Hi @hvanderheide

Thank you for your submission and fix.

There's a little bit more needed to qualify this PR ready for review and merging.

• Would you please add raw cli output for project unit tests?
• Please generated structured YAML off of the raw output using the helper scripts.
• And run the test cases via invoke.

If there are any questions, please ask. Thank you!

[hvanderheide]

There's a little bit more needed to qualify this PR ready for review and merging.

Hi @mjbear, thanks for helping me through the process. I've added a test case with both the raw output and a YAML file. The test seems to succeed.

Decided to add more test data.
I will need to re-review after that.

[mjbear]

I saw the comment from the previous contributor that is getting removed regarding "works on 3850, but not 3750". 😅

I decided to poke at some other hardware to round out the support.

😱 Oh and this is one of those (existing) templates without the Error directive.

The index pattern can be shortened to show env power all (as confirmed on a Cisco command reference).
(And likewise show env temperature for another related template.)

---

Here's a list of things I changed and pushed to your PR/branch.

• Added Error directive
• Updated index pattern (which allows this to support older switches too)
• Added support for some older cli output

[mjbear]

@itdependsnetworks @jmcgill298 @jvanderaa @matt852
Could I get a second set of eyes on this PR?
(I made changes to the index which should be fine based on research, but it never hurts to have other reviewers!)

[jvanderaa]

I'm tempted that we shouldn't reduce the command length matching part. There are likely other platforms that may have a command issue there. @itdependsnetworks / @jmcgill298 I'm going to need some of your thoughts there.

[jmcgill298]

LGTM. Even if newer versions have two different commands that start with env, then the user would have to add the fourth letter, and then that would not match the pattern in the index