Open
Conversation
Owner
|
Hello @SergeyLisitsyn , All seems to be ok to me, thanks for you contribution. Do you plan to implement the getCoords() function, or do I merge your pull-request without it ? |
Author
|
Hi, Vincent Brouté,
I am new in that and I'm not sure if that map is right generated. I prefer
to wait until customer check out the map.
Thanks, I forgot to put in js file getCoords() function despite I created
it earlier.
I think, I will fix all issues and will commit a new file version.
Thank you for comprehension.
Sergey.
P.S. l will plan continue to make all provinces of Ukraine further if my
project will continue too.
…On Thu, Sep 13, 2018, 19:33 Vincent Brouté ***@***.***> wrote:
Hello @SergeyLisitsyn <https://github.com/SergeyLisitsyn> ,
All seems to be ok to me, thanks for you contribution. Do you plan to
implement the getCoords() function, or do I merge your pull-request without
it ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#55 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGHOAzj-lbPD_r1lcQmDOp-aJrILcMwMks5uaojHgaJpZM4Wf32_>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.