Add Arab world map in it context in the middle east#56
Open
disooqi wants to merge 1 commit intoneveldo:masterfrom
Open
Add Arab world map in it context in the middle east#56disooqi wants to merge 1 commit intoneveldo:masterfrom
disooqi wants to merge 1 commit intoneveldo:masterfrom
Conversation
Owner
|
Hello @disooqi , Sorry for my late answer, and thanks a lot for your contribution to the repository ! Some things should be fixed before your PR being able to be merged into the master branch :
Feel free to take a look at the other map added in this repository, for instance : https://github.com/neveldo/mapael-maps/tree/7ef1b5c7cc0f820e63dac0cbfeef47392b74988c/croatia |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just created a map for the Arab world within it context in the middle east. I added three files: 1) "arabworld2.js" which contains the actual map data 2) "index.js" which contain js code to highlight the Arabic countries, and finally 3) "index.html" that only shows the map in a webpage