Skip to content

Conversation

@tviaud
Copy link

@tviaud tviaud commented Sep 22, 2025

Description

This pull request adds support for configuring resource requests and limits for the admission-create and admission-patch Kubernetes jobs in the nri-metadata-injection Helm chart.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Add changelog entry following the contributing guide
  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

@tviaud tviaud requested a review from a team as a code owner September 22, 2025 15:05
Copy link
Contributor

@dbudziwojskiNR dbudziwojskiNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! We would also need helm unit tests added that covers this new functionality.

tviaud and others added 4 commits October 29, 2025 10:27
Co-authored-by: Daniel Budziwojski <dbudziwojski@newrelic.com>
Co-authored-by: Daniel Budziwojski <dbudziwojski@newrelic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants